feat: coretime implementation - #1558
Merged
Merged
Conversation
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
November 29, 2024 15:52
744895d to
6de3395
Compare
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
December 9, 2024 15:15
4efc743 to
f6e8a77
Compare
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
December 19, 2024 15:59
9ef9d68 to
e8a0808
Compare
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
December 20, 2024 11:12
142039d to
4dcdf17
Compare
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
reviewed
Dec 20, 2024
TarikGul
requested changes
Dec 20, 2024
TarikGul
left a comment
Member
There was a problem hiding this comment.
Overall amazing PR! I have a few nits:
-
The typecasting can be removed. AFAIU the types are correctly passed down from PJS so you should be good.
-
For any imported types we can use
import type.
Other than that the PR looks really great!
Contributor
Author
I removed most of typecasting (nice catch, not sure I was having issues before), I had to leave typecasting for coreDescriptors and paraLifecycles though, we can doublecheck if there is something wrong on my end though
thanks for checking it out! |
Imod7
requested changes
Jan 1, 2025
Imod7
left a comment
Contributor
There was a problem hiding this comment.
Some minor comments and a question. Looks great! 🎉
Contributor
Author
Nice catches, thanks! On it |
Imod7
approved these changes
Jan 7, 2025
Imod7
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating! All Good! ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Feature: Implements the coretime endpoints for relay chain and for coretime chain.
It includes basic endpoints for single information record recovery, and more advanced endpoints with precomputed calculations and information.