additional support to allow frame-metadata to derive TypeInfo#163
Merged
Conversation
Contributor
|
Cool! Do we even want these behind a feature flag? It seemsl ike a generally useful and not super invasive change to make generally. The only thing I don't like so much is the manual impl/use on |
Contributor
|
Ah since this is just merging into that other branch, I have no objection with you just going for the merge whenever you like :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to see whether I can make frame-metadata have TypeInfos so that I can try decoding it in a no_std context. To do so it looks like these types need type info to get something that compiles.