Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Xcm-Emulator: use ext_wrapper to execute with externalities#2893

Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-xcm-emulator-fix-recur
Jul 19, 2023
Merged

Xcm-Emulator: use ext_wrapper to execute with externalities#2893
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-xcm-emulator-fix-recur

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented Jul 18, 2023

The processing of an XCM message should not trigger the network to process all the XCM channels, which happens if execute with execute_with.
The ext_wrapper will wrap the execution only with test externalities.

@muharem muharem added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 18, 2023
@muharem muharem requested review from NachoPal and bkontur July 18, 2023 16:18
bkontur
bkontur approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NachoPal @muharem
can you guys, please, add some docs/description to the:

        fn execute_with<R>(execute: impl FnOnce() -> R) -> R;
	fn ext_wrapper<R>(func: impl FnOnce() -> R) -> R;

they have the same signature but would be good to know what is the difference

@muharem
Copy link
Contributor Author

muharem commented Jul 19, 2023

@bkontur there is a branch with that from @NachoPal, coming soon

@muharem
Copy link
Contributor Author

muharem commented Jul 19, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 99d4b82 into master Jul 19, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-xcm-emulator-fix-recur branch July 19, 2023 08:53
muharem added a commit that referenced this pull request Jul 19, 2023
@muharem
use ext_wrapper instead execute_with (#2893)
f3f8bec
girazoki pushed a commit to moondance-labs/cumulus that referenced this pull request Aug 18, 2023
@muharem @girazoki
use ext_wrapper instead execute_with (paritytech#2893)
d3f3c13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bkontur bkontur bkontur approved these changes

@NachoPal NachoPal NachoPal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muharem @bkontur @NachoPal