Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add Support for Foreign Assets#2133

Merged
paritytech-processbot[bot] merged 30 commits into
masterfrom
joe-foreign-assets
Mar 23, 2023
Merged

Add Support for Foreign Assets#2133
paritytech-processbot[bot] merged 30 commits into
masterfrom
joe-foreign-assets

Conversation

@joepetrowski

@joepetrowski joepetrowski commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Adds support to Statemine and Westmint for foreign fungible assets. This will allow other parachains to represent their assets, as well as bridges to represent assets from other networks, on Statemine. A follow up PR will introduce this to Statemint once it has been audited and in the Kusama coal mines for some time.

@joepetrowski joepetrowski added A3-in_progress Pull request is in progress. No review needed at this stage. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 24, 2023
@paritytech-ci paritytech-ci requested review from a team January 24, 2023 13:30
@joepetrowski joepetrowski added T7-system_parachains This PR/Issue is related to System Parachains. T6-XCM This PR/Issue is related to XCM. T8-bridges This PR/Issue is related to bridges. labels Jan 24, 2023
@bkontur

bkontur commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

bot rebase

@joepetrowski joepetrowski added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jan 31, 2023
@joepetrowski

Copy link
Copy Markdown
Contributor Author

bot rebase

@joepetrowski

Copy link
Copy Markdown
Contributor Author

bot rebase

@Polkadot-Forum

Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/statemint-update-roadmap/1200/94

@gilescope gilescope mentioned this pull request Feb 13, 2023
@joepetrowski joepetrowski removed T7-system_parachains This PR/Issue is related to System Parachains. T6-XCM This PR/Issue is related to XCM. T8-bridges This PR/Issue is related to bridges. labels Feb 14, 2023
@bkontur

bkontur commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

bot rebase

@bkontur

bkontur commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

bot rebase

@bkontur

bkontur commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

bot rebase

@bkchr bkchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a high level, haven't done an in depth review

Comment thread parachains/runtimes/assets/westmint/src/xcm_config.rs Outdated
Comment thread parachains/runtimes/assets/common/src/matching.rs Outdated
@bkontur

bkontur commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

bot rebase

1 similar comment
@bkontur

bkontur commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

bot rebase

@paritytech-processbot

Copy link
Copy Markdown

Rebased

@bkontur

bkontur commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

bot merge

@paritytech-processbot

Copy link
Copy Markdown

Waiting for commit status.

@paritytech-processbot paritytech-processbot Bot merged commit 020a024 into master Mar 23, 2023
@paritytech-processbot paritytech-processbot Bot deleted the joe-foreign-assets branch March 23, 2023 14:14
ordian added a commit that referenced this pull request Mar 23, 2023
* master:
  Add Support for Foreign Assets (#2133)
  XCM V2 weight template (#2344)
  Companion for polkadot#6928 (#2356)
  move back to ci-linux@production image
@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 5, 2023
@Polkadot-Forum

Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/bridge-hub-questions/2693/2

@Polkadot-Forum

Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants