Skip to content

Conversation

@amadeus
Copy link
Collaborator

@amadeus amadeus commented Jun 26, 2016

Misc fixes for the JS Flow plugin.

@amadeus amadeus merged commit dbfa5f0 into develop Jun 26, 2016
@amadeus amadeus deleted the flow-updates branch June 26, 2016 00:08
@gf3
Copy link
Contributor

gf3 commented Jun 28, 2016

getting some leakage from jsFlowTypeObject after this last merge:

screen shot 2016-06-28 at 2 24 19 pm

@gf3
Copy link
Contributor

gf3 commented Jun 28, 2016

if you add ; to the end regex of jsFlowTypeValue it works as expected

@amadeus
Copy link
Collaborator Author

amadeus commented Jun 28, 2016

Can you create a new issue with a quick example broken snippet? I'll get on fixing these ASAP.

@gf3
Copy link
Contributor

gf3 commented Jun 28, 2016

i'll open a PR in a couple mins

@amadeus
Copy link
Collaborator Author

amadeus commented Jun 28, 2016

@gf3 I do have a branch I am fixing a couple things in currently, so I may have already fixed this issue in that branch.

@gf3
Copy link
Contributor

gf3 commented Jun 28, 2016

okay, issue created → #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants