remove ops div class to solve #21374 #59144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 28, 2024 16:05
mroeschke
reviewed
Jul 1, 2024
mroeschke
reviewed
Jul 1, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Jul 1, 2024
Member
|
Thanks @mutricyl |
3 tasks
bnavigator
added a commit
to bnavigator/pandas
that referenced
this pull request
Aug 17, 2024
bnavigator
added a commit
to bnavigator/pandas
that referenced
this pull request
Aug 17, 2024
…olve pandas-dev#2137) * remove core.computation.ops.Div resolves pandas-dev#21374 pandas-dev#58748 * need to preserve order * updating tests * (update whatsnew -- no whatsnew for 2.2.x and 2.3 yet) * solve mypy issue * fixing pytests * better than cast * adding specific test (* Update pandas/tests/frame/test_query_eval.py // Not backported, fails on 2.2) Co-authored-by: Matthew Roeschke <[email protected]> * Update pandas/tests/computation/test_eval.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Laurent Mutricy <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
5 tasks
bnavigator
added a commit
to bnavigator/pandas
that referenced
this pull request
Aug 17, 2024
…olve pandas-dev#2137) * remove core.computation.ops.Div resolves pandas-dev#21374 pandas-dev#58748 * need to preserve order * updating tests * (update whatsnew -- no whatsnew for 2.2.x and 2.3 yet) * solve mypy issue * fixing pytests * better than cast * adding specific test (* Update pandas/tests/frame/test_query_eval.py // Not backported, fails on 2.2) Co-authored-by: Matthew Roeschke <[email protected]> * Update pandas/tests/computation/test_eval.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Laurent Mutricy <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
* remove core.computation.ops.Div resolves pandas-dev#21374 pandas-dev#58748 * need to preserve order * updating tests * update whatsnew * solve mypy issue * fixing pytests * better than cast * adding specific test * Update pandas/tests/frame/test_query_eval.py Co-authored-by: Matthew Roeschke <[email protected]> * Update pandas/tests/computation/test_eval.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Laurent Mutricy <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
lithomas1
added a commit
that referenced
this pull request
Sep 18, 2024
#59535) * remove core.computation.ops.Div resolves #21374 #58748 * need to preserve order * updating tests * (update whatsnew -- no whatsnew for 2.2.x and 2.3 yet) * solve mypy issue * fixing pytests * better than cast * adding specific test (* Update pandas/tests/frame/test_query_eval.py // Not backported, fails on 2.2) * Update pandas/tests/computation/test_eval.py --------- Co-authored-by: Laurent Mutricy <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.core.computation.div.ops.Divclass that was introduced to manage unexpected upcast from float32 to float64 looks to be responsible of the imaginary part of complexes being dropped. It seams that numpy and numexpr have evolved since #12388 and this fix is no more needed.This PR removes
core.computation.div.ops.Divclass and extends tests to cover for both floats and complex.