Merged
Conversation
Basically, this commit glues together the changes from #2064 and oxidecomputer/management-gateway-service#390. The `SpHandler::set_power_state` implementation for compute sleds in the `control-plane-agent` task now report the outcome of power state transitions using the new `gateway_messages::PowerStateTransition` type added in oxidecomputer/management-gateway-service#390. This fixes oxidecomputer/management-gateway-service#270, and closes oxidecomputer/management-gateway-service#271. We'll need to update MGS proper (in the Omicron repo) to pick up the new `gateway-messages` changes, as well.
mkeeter
approved these changes
May 12, 2025
Collaborator
mkeeter
left a comment
There was a problem hiding this comment.
I didn't test this on hardware, but it looks reasonable to me!
Contributor
|
Yep, LGTM too. Tagged this as R16 since we need to ship an MGS that knows how to receive this response in R15 first to keep wicket happy. |
Member
Author
|
Yup, that's right. Unfortunately untangling the various knots necessary to pick up the MGS changes in Omicron will require untangling an entire stack of my nonsense, but what can you do? |
Member
Author
|
(by which i mean: i'm gonna go do that. in case that wasn't clear) |
hawkw
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 14, 2025
This commit updates the MGS repo git dependencies to oxidecomputer/management-gateway-service@0e1e055. This picks up the following commits: - oxidecomputer/management-gateway-service#389: Clap bump - oxidecomputer/management-gateway-service#390: Make no-op `SetPowerState` calls succeed; needed to unblock oxidecomputer/hubris#2065 merging for R16 - oxidecomputer/management-gateway-service#388: Remove an unused flag bit from the ereport protocol - oxidecomputer/management-gateway-service#391: Adds debug impls for the new `PowerStateTransition` type added in oxidecomputer/management-gateway-service#390 Most of these commits are mine, and should be relatively low risk to merge --- trust me. 😇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, this commit glues together the changes from #2064 and
oxidecomputer/management-gateway-service#390. The
SpHandler::set_power_stateimplementation for compute sleds in thecontrol-plane-agenttask now report the outcome of power state transitions using the new
gateway_messages::PowerStateTransitiontype added in oxidecomputer/management-gateway-service#390.This fixes oxidecomputer/management-gateway-service#270, and closes oxidecomputer/management-gateway-service#271.
We'll need to update MGS proper (in the Omicron repo) to pick up the new
gateway-messageschanges, as well.Fixes #1466