Build an instance spec for the latest propolis

[jmpesp]

Update to use the latest propolis-server API: build an instance spec instead of the TOML file, and send that in the instance ensure.

Fixes #126

[rcgoodfellow]

Poking around in a4x2, illumos seems a bit mad about a uart

ry@masaka:~/src/testbed/a4x2$ pfexec ./a4x2 serial g0
Entering VM console.
Use ^q to exit.
Press enter to continue.
pr  9 19:59:11 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:11 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8
Apr  9 19:59:16 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:16 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8

g0 console login: Apr  9 19:59:21 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:21 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8
Apr  9 19:59:26 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:26 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8

g0 console login:
g0 console login: Apr  9 19:59:31 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:31 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8

g0 console login: Apr  9 19:59:36 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:36 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8
Apr  9 19:59:41 unknown asy: WARNING: asy1: UART @ 2f8 scratch register: expected 0x5a, got 0xff
Apr  9 19:59:41 unknown asy: WARNING: asy1: Cannot identify UART chip at 2f8

[gjcolombo]

0x2F8 is the I/O port address for COM2. Propolis used to add all of COM1-COM3 implicitly to Falcon VMs, but it now requires them to be specified explicitly in the instance ensure inputs. I think the fix here might be to add COM2 and COM3 in Node::preflight (right-side line 789 of lib/src/lib.rs in this PR); as the rest of the function notes, COM4 will be enabled implicitly by the SoftNpuPciPort device that's already in the spec.

[jmpesp]

0x2F8 is the I/O port address for COM2. Propolis used to add all of COM1-COM3 implicitly to Falcon VMs, but it now requires them to be specified explicitly in the instance ensure inputs. I think the fix here might be to add COM2 and COM3 in Node::preflight (right-side line 789 of lib/src/lib.rs in this PR); as the rest of the function notes, COM4 will be enabled implicitly by the SoftNpuPciPort device that's already in the spec.

👍 thanks for digging into that, pushed the suggestion in a609c6d

[rcgoodfellow]

Things are looking better after a609c6d

[rcgoodfellow]

Thanks @jmpesp! LGTM and a4x2 is working.

[gjcolombo]

Thanks for putting this together!