Revert "dispatch event for 404 errors"#34835
Merged
karakayasemi merged 1 commit intomasterfrom Mar 19, 2019
Merged
Conversation
9 tasks
phil-davis
reviewed
Mar 19, 2019
This reverts commit c1cf05a.
820410f to
1c7e663
Compare
Codecov Report
@@ Coverage Diff @@
## master #34835 +/- ##
============================================
+ Coverage 65.31% 65.34% +0.03%
+ Complexity 18481 18478 -3
============================================
Files 1209 1208 -1
Lines 69984 69943 -41
Branches 1280 1280
============================================
Hits 45707 45707
+ Misses 23905 23864 -41
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34835 +/- ##
============================================
+ Coverage 65.31% 65.34% +0.03%
+ Complexity 18481 18478 -3
============================================
Files 1209 1208 -1
Lines 69984 69943 -41
Branches 1280 1280
============================================
Hits 45707 45707
+ Misses 23905 23864 -41
Partials 372 372
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c1cf05a.
Description
Remove unused 404 events.
Related Issue
#28523 (comment)
Motivation and Context
To not spent effort for maintaining and keeping stable in the future as discussed in here: #28523 (comment)
Screenshots (if appropriate):
Types of changes
Checklist: