Skip to content

Update minimum supported browser versions#29505

Merged
PVince81 merged 1 commit intomasterfrom
browser-min-versions-2017-11
Nov 8, 2017
Merged

Update minimum supported browser versions#29505
PVince81 merged 1 commit intomasterfrom
browser-min-versions-2017-11

Conversation

@phil-davis
Copy link
Contributor

Description

Update the minimum supported browser versions. Note that this code expects the number of the last version that is NOT supported.

  1. IE - no change, <=10 is not supported, need IE11
  2. Firefox - current release is 56 and previous 55, <=54 is not supported
  3. Safari - bump minimum to 10, <=9 is not supported
  4. Chrome - current release is 62, previous 61, <=60 is not supported

Note: The JScript that uses these numbers also has code for FirefoxESR and already knows that Firefox ESR 52 is the "OK" version. So it should also pass anyone running Firefox ESR 52.

Related Issue

#28016

Motivation and Context

ownCloud is tested with currently supported browser versions, so warn users if they are using an older browser version.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Doc update is required once the exact versions are agreed here.

@phil-davis phil-davis added this to the development milestone Nov 8, 2017
@phil-davis phil-davis self-assigned this Nov 8, 2017
@phil-davis
Copy link
Contributor Author

Note automated CI testing happens for:

  • chrome latest (=62 today)
  • chrome latest-1 (=61 today)
  • IE11
  • Edge
  • Firefox47 (because it works - but is too old to say it is supported)

Automated tests can be run locally for:

Safari tests are not automated. QA uses Safari (among other browsers) during manual testing.

@phil-davis
Copy link
Contributor Author

This change will cause users on older browsers to get a "browser is out of date" message. That could be a user experience issue on corporate computers if browser versions are old and the end-user has no control to do anything about it. So what is the "release to the wild" process for this kind of thing?

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #29505 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29505   +/-   ##
=========================================
  Coverage     60.86%   60.86%           
  Complexity    17240    17240           
=========================================
  Files          1032     1032           
  Lines         57388    57388           
=========================================
  Hits          34927    34927           
  Misses        22461    22461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b996e08...71356dd. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 8a25ef5 into master Nov 8, 2017
@PVince81 PVince81 deleted the browser-min-versions-2017-11 branch November 8, 2017 10:35
@PVince81
Copy link
Contributor

PVince81 commented Nov 8, 2017

@phil-davis quick backport?

@phil-davis
Copy link
Contributor Author

Backport stable10 #29507

phil-davis added a commit to owncloud-archive/documentation that referenced this pull request Nov 8, 2017
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants