Make it private, not protected, in Share20OCS#29493
Merged
Conversation
jvillafanez
approved these changes
Nov 7, 2017
Codecov Report
@@ Coverage Diff @@
## master #29493 +/- ##
=========================================
Coverage 60.85% 60.85%
Complexity 17240 17240
=========================================
Files 1032 1032
Lines 57372 57372
=========================================
Hits 34912 34912
Misses 22460 22460
Continue to review full report at Codecov.
|
Contributor
|
It also makes me happy, not only @jvillafanez 🤣 |
Contributor
Author
|
@mrow4a I'll think of you next time I make a branch |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29457 (comment)
@jvillafanez
No backports, master only