Skip to content

Add dispatcher event for remote fed shares#29481

Merged
sharidas merged 1 commit intomasterfrom
remote-fedshare-dispatcher-event
Nov 7, 2017
Merged

Add dispatcher event for remote fed shares#29481
sharidas merged 1 commit intomasterfrom
remote-fedshare-dispatcher-event

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Nov 7, 2017

Adding dispatcher events for remote fed shares

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Dispatcher event for remote fed shares.

Related Issue

Motivation and Context

This change will help users to catch the events and log it.

How Has This Been Tested?

  • Create a fed1 folder from a remote oC instance1
  • Share to another oC instance2.
  • When oC instance2 accepts/rejects the share the logs are available at oC2 instance.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sharidas sharidas self-assigned this Nov 7, 2017
@sharidas sharidas added this to the development milestone Nov 7, 2017
@sharidas sharidas requested a review from PVince81 November 7, 2017 07:28
@sharidas sharidas force-pushed the remote-fedshare-dispatcher-event branch from 37bb0c9 to 404f45f Compare November 7, 2017 07:50
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #29481 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29481      +/-   ##
============================================
+ Coverage     60.84%   60.85%   +0.01%     
  Complexity    17238    17238              
============================================
  Files          1032     1032              
  Lines         57365    57380      +15     
============================================
+ Hits          34904    34919      +15     
  Misses        22461    22461
Impacted Files Coverage Δ Complexity Δ
...aring/lib/Controllers/ExternalSharesController.php 95.83% <100%> (+1.89%) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da7b8e...404f45f. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #29481 into master will increase coverage by <.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29481      +/-   ##
============================================
+ Coverage     60.84%   60.85%   +<.01%     
  Complexity    17238    17238              
============================================
  Files          1032     1032              
  Lines         57365    57381      +16     
============================================
+ Hits          34904    34919      +15     
- Misses        22461    22462       +1
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/AppInfo/Application.php 44.26% <0%> (-0.74%) 4 <0> (ø)
...aring/lib/Controllers/ExternalSharesController.php 95.83% <100%> (+1.89%) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da7b8e...3749986. Read the comment docs.

@sharidas
Copy link
Contributor Author

sharidas commented Nov 7, 2017

Backport for stable10 : #29482

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not inject it directly ? you're in the perfect setup to do so as controllers are DI'd automagically

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix DI then this looks good

Adding dispatcher events for remote fed shares

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas force-pushed the remote-fedshare-dispatcher-event branch from 404f45f to 3749986 Compare November 7, 2017 08:50
@sharidas
Copy link
Contributor Author

sharidas commented Nov 7, 2017

Injected EventDispatcherInterface.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sharidas sharidas merged commit 4fdfe0c into master Nov 7, 2017
@sharidas sharidas deleted the remote-fedshare-dispatcher-event branch November 7, 2017 12:03
@SergioBertolinSG SergioBertolinSG modified the milestones: development, QA Nov 28, 2017
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants