Exclude mimetypelist.js from signing/integrity check

[VicDeo]

Description

Adds regex exclusions by path/filename into ExcludeFileByNameFilterIterator

Related Issue

Fixes #29277

Motivation and Context

Signing core/js/mimetypelist.js

How Has This Been Tested?

Unit-tested

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #29308 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #29308      +/-   ##
============================================
+ Coverage     59.59%   59.59%   +<.01%     
+ Complexity    17170    17169       -1     
============================================
  Files          1029     1029              
  Lines         57238    57234       -4     
============================================
- Hits          34113    34111       -2     
+ Misses        23125    23123       -2

Impacted Files	Coverage Δ	Complexity Δ
lib/private/IntegrityCheck/Checker.php	92.59% <ø> (+0.62%)	60 <0> (-3)	⬇️
...Check/Iterator/ExcludeFileByNameFilterIterator.php	100% <100%> (ø)	7 <0> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558e298...8c8c354. Read the comment docs.

[PVince81]

you likely still need to keep something here to prevent generating the hashes in the first place ?

[VicDeo]

@PVince81 generateHashes takes a folder iterator. I excluded this path from the items returned by this iterator.

[VicDeo]

It's reused everywhere, so I basically made core/js/mimetypelist.js completely invisible for signing code. See

core/lib/private/IntegrityCheck/Checker.php

Line 157 in 8c8c354

private function generateHashes(\RecursiveIteratorIterator $iterator,

core/lib/private/IntegrityCheck/Checker.php

Line 386 in 8c8c354

$currentInstanceHashes = $this->generateHashes($this->getFolderIterator($basePath), $basePath);

[PVince81]

👍 thanks for clarifying

[PVince81]

@VicDeo please backport to stable10

[VicDeo]

Stable10: #29316

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.