Skip to content

Corrected namespace for OC\Memcache\ArrayCache#29213

Merged
PVince81 merged 1 commit intoowncloud:masterfrom
mdusher:master
Oct 12, 2017
Merged

Corrected namespace for OC\Memcache\ArrayCache#29213
PVince81 merged 1 commit intoowncloud:masterfrom
mdusher:master

Conversation

@mdusher
Copy link
Contributor

@mdusher mdusher commented Oct 12, 2017

Description

Class 'OC\\MemCache\\ArrayCache' not found exception being thrown for some external shares (in my case, it was external shares that existed in the oc_share_external table prior to upgrading to 10.0.3) due to incorrect case for the namespace name.

Related Issue

#29212

Motivation and Context

To make external sharing work and it solves an exception.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

`Class 'OC\\MemCache\\ArrayCache' not found` exception being thrown for some external shares due to incorrect case for the namespace name.
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! 🎉
Please sign the CLA by following the instructions above - THX

@PVince81
Copy link
Contributor

@mdusher thanks a lot. Strange that this wasn't discovered before. Maybe different PHP versions are more tolerant with this.

I grepped the source code and did not find any other instances of misspelled case.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

stable10: #29219

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants