Admins can change display name when flag set to false by sharidas · Pull Request #29132 · owncloud/core

sharidas · 2017-10-02T12:47:46Z

When 'allow_user_to_change_display_name' => false, is
set in the config.php then admin user should be
able to set the display name.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When 'allow_user_to_change_display_name' => false, is set in the config.php, then the admin user should be able to set the display name of users.

Related Issue

#27442

Motivation and Context

When 'allow_user_to_change_display_name' => false, is set in the config.php, the admin user wasn't able to set the display name. This change will help to allow the admin to set the display name for users.

How Has This Been Tested?

create 3 users admin, user1, user2
Add 'allow_user_to_change_display_name' => false, to the config.php
Login as admin user and try to rename the admin to "Foo". It worked.
Create a new group test and add user1 and user2 to the group test.
Make user1 as the group admin for test1.
Now try to login as user then try to change the display name for user1, it worked.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

sharidas · 2017-10-03T07:10:24Z

Made modification so that admin and group admins can change the display name. It would be nice to know if we want to have only

admins and group admins to change the display name of users
or only admins allowed to change display name

DeepDiver1975 · 2017-10-05T19:33:27Z

Any chance to get this unit tested? THX

PVince81 · 2017-10-10T13:38:08Z

@sharidas I think any kind of admin should be able to change the display name. Non-admins aka users should not.

sharidas · 2017-10-10T13:42:14Z

So if I understand correctly

admins and group admins to change the display name of users
Admins and group admins are allowed to change the display name if allow_user_to_change_display_name' => false, is added to config.php

PVince81 · 2017-10-10T14:30:27Z

@sharidas correct

PVince81 · 2017-10-10T14:30:39Z

@pmaier1 FYI ^

sharidas · 2017-10-10T15:20:38Z

Now an admin and group admin can change the users display name

PVince81 · 2017-10-10T15:24:17Z

@sharidas please adjust unit tests. If there are none, please add some. Thanks

sharidas · 2017-10-10T15:40:40Z

please adjust unit tests. If there are none, please add some. Thanks

Thats next task.

sharidas · 2017-11-03T07:05:48Z

lib/private/User/User.php

Injecting GroupManager and UserSession here. Didn't liked the previous version of the patch. So used this approach. Let me know if it looks ok to inject here.

Have also added unit test for the same.

codecov · 2017-11-03T07:15:34Z

Codecov Report

Merging #29132 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #29132      +/-   ##
============================================
+ Coverage     60.45%   60.46%   +<.01%     
- Complexity    17222    17226       +4     
============================================
  Files          1032     1032              
  Lines         57360    57368       +8     
============================================
+ Hits          34677    34686       +9     
+ Misses        22683    22682       -1

Impacted Files	Coverage Δ	Complexity Δ
lib/private/User/User.php	`82.82% <100%> (+1.53%)`	`63 <0> (+4)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2654cbc...6a75852. Read the comment docs.

PVince81

👍

sharidas · 2017-11-03T15:00:26Z

Will create backport.

sharidas · 2017-11-03T15:05:44Z

Backport to stable10: #29442

DeepDiver1975 · 2017-11-03T15:24:21Z

16:07:28 [owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q] Running shell script
16:07:28 + export NOCOVERAGE=1
16:07:28 + NOCOVERAGE=1
16:07:28 + unset USEDOCKER
16:07:28 + phpenv local 5.6
16:07:28 + make test-php TEST_DATABASE=pgsql
16:07:28 PHPUNIT="/var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/phpunit/phpunit/phpunit" build/autotest.sh pgsql 
16:07:28 Using PHP executable /opt/phpenv/shims/php
16:07:28 Parsing all files in lib/public for the presence of @since or @deprecated on each method...
16:07:28 
16:07:30 Using database oc_autotest5
16:07:30 Setup environment for pgsql testing on local storage ...
16:07:34 Installing ....
16:07:52 PHP Fatal error:  Cannot use OC\Group\Manager as Manager because the name is already in use in /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/User/User.php on line 41
16:07:52 PHP Stack trace:
16:07:52 PHP   1. {main}() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/occ:0
16:07:52 PHP   2. require_once() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/occ:11
16:07:52 PHP   3. OC\Console\Application->run() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/console.php:106
16:07:52 PHP   4. Symfony\Component\Console\Application->run() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/Console/Application.php:162
16:07:52 PHP   5. Symfony\Component\Console\Application->doRun() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/symfony/console/Application.php:130
16:07:52 PHP   6. Symfony\Component\Console\Application->doRunCommand() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/symfony/console/Application.php:228
16:07:52 PHP   7. Symfony\Component\Console\Command\Command->run() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/symfony/console/Application.php:874
16:07:52 PHP   8. OC\Core\Command\Maintenance\Install->execute() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/symfony/console/Command/Command.php:264
16:07:52 PHP   9. OC\Setup->install() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/core/Command/Maintenance/Install.php:86
16:07:52 PHP  10. OC\User\Manager->createUser() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/Setup.php:347
16:07:52 PHP  11. OC\User\Manager->getUserObject() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/User/Manager.php:336
16:07:52 PHP  12. spl_autoload_call() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/User/Manager.php:180
16:07:52 PHP  13. Composer\Autoload\ClassLoader->loadClass() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/private/User/Manager.php:180
16:07:52 PHP  14. Composer\Autoload\includeFile() /var/lib/jenkins/workspace/owncloud-core_core_PR-29132-2PBBEYQ3IXYKPHPI4JLRKSIPJOYVTQEFY26WO6EJ72XKCBDAG24Q/lib/composer/composer/ClassLoader.php:322

DeepDiver1975

#29132 (comment)

When 'allow_user_to_change_display_name' => false, is set in the config.php then admin user should be able to set the display name. Signed-off-by: Sujith H <sharidasan@owncloud.com>

sharidas · 2017-11-05T09:39:06Z

All checks passed.

lock · 2019-08-02T01:02:58Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

sharidas self-assigned this Oct 2, 2017

sharidas added the 2 - Developing label Oct 2, 2017

sharidas added this to the development milestone Oct 2, 2017

sharidas force-pushed the admin-change-display-name branch from 3aacaa5 to 4e57dff Compare October 3, 2017 07:06

sharidas added 3 - To Review and removed 2 - Developing labels Oct 3, 2017

sharidas changed the title ~~[WIP] Admins can change display name when flag set to false~~ Admins can change display name when flag set to false Oct 3, 2017

sharidas requested review from DeepDiver1975 and PVince81 October 3, 2017 09:31

sharidas force-pushed the admin-change-display-name branch from 4e57dff to 803770b Compare October 3, 2017 11:04

sharidas force-pushed the admin-change-display-name branch from 803770b to d2fe69f Compare October 10, 2017 15:21

sharidas force-pushed the admin-change-display-name branch from d2fe69f to 648f118 Compare November 3, 2017 06:55

sharidas commented Nov 3, 2017

View reviewed changes

sharidas force-pushed the admin-change-display-name branch 2 times, most recently from 8ba23cf to 6e1e30c Compare November 3, 2017 14:44

PVince81 approved these changes Nov 3, 2017

View reviewed changes

PVince81 added 4 - To release and removed 3 - To Review labels Nov 3, 2017

sharidas mentioned this pull request Nov 3, 2017

[stable10] Admins can change display name when flag set to false #29442

Merged

9 tasks

sharidas added the backport-request label Nov 3, 2017

PVince81 removed the backport-request label Nov 3, 2017

DeepDiver1975 added 2 - Developing and removed 4 - To release labels Nov 3, 2017

DeepDiver1975 requested changes Nov 3, 2017

View reviewed changes

Admins can change display name when flag set to false

6a75852

When 'allow_user_to_change_display_name' => false, is set in the config.php then admin user should be able to set the display name. Signed-off-by: Sujith H <sharidasan@owncloud.com>

sharidas force-pushed the admin-change-display-name branch from 6e1e30c to 6a75852 Compare November 3, 2017 16:04

PVince81 merged commit 6a3a485 into master Nov 6, 2017

PVince81 deleted the admin-change-display-name branch November 6, 2017 09:33

ownclouders added the status/STALE label Dec 20, 2017

lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Conversation

sharidas commented Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

sharidas commented Oct 3, 2017

Uh oh!

DeepDiver1975 commented Oct 5, 2017

Uh oh!

PVince81 commented Oct 10, 2017

Uh oh!

sharidas commented Oct 10, 2017

Uh oh!

PVince81 commented Oct 10, 2017

Uh oh!

PVince81 commented Oct 10, 2017

Uh oh!

sharidas commented Oct 10, 2017

Uh oh!

PVince81 commented Oct 10, 2017

Uh oh!

sharidas commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharidas Nov 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sharidas Nov 3, 2017

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PVince81 left a comment

Choose a reason for hiding this comment

Uh oh!

sharidas commented Nov 3, 2017

Uh oh!

sharidas commented Nov 3, 2017

Uh oh!

DeepDiver1975 commented Nov 3, 2017

Uh oh!

DeepDiver1975 left a comment

Choose a reason for hiding this comment

Uh oh!

sharidas commented Nov 5, 2017

Uh oh!

lock bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sharidas commented Oct 2, 2017 •

edited

Loading

sharidas commented Oct 10, 2017 •

edited

Loading

sharidas Nov 3, 2017 •

edited

Loading

codecov bot commented Nov 3, 2017 •

edited

Loading