Skip to content

Use correct class namespace for ownCloud ext storage#28931

Merged
PVince81 merged 1 commit intomasterfrom
extstorage-oc-nopartfile
Sep 11, 2017
Merged

Use correct class namespace for ownCloud ext storage#28931
PVince81 merged 1 commit intomasterfrom
extstorage-oc-nopartfile

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 6, 2017

Description

Fixes uploading to remote ownCloud external storages by properly
disabling part files when detecting the correct class name.

Related Issue

Fixes #28929

Motivation and Context

How Has This Been Tested?

See steps in ticket

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davitol
Copy link
Contributor

davitol commented Sep 6, 2017

@PVince81 It solves the bug for owncloud external storage, but not for the webDav one

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 6, 2017

@davitol don't use "Webdav" storage when connecting to a remote ownCloud, it won't work due to part files. We need to keep part file support when dealing with regular Webdav servers.

@davitol
Copy link
Contributor

davitol commented Sep 6, 2017

@PVince81 Thanks for the clarification. 👍

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly 👍 I have verified #28899 change and that too worked fine.

Fixes uploading to remote ownCloud external storages by properly
disabling part files when detecting the correct class name.
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 7, 2017

stable10: #28935

@PVince81 PVince81 merged commit 909416e into master Sep 11, 2017
@PVince81 PVince81 deleted the extstorage-oc-nopartfile branch September 11, 2017 11:43
@PVince81
Copy link
Contributor Author

stable9.1: #28978

skipped stable9 as that one only receives security updates

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot upload a file using external oC mount instance

4 participants