Handle no user session in isSharingDisabledForUser()

[phil-davis]

Description

If isSharingDisabledForUser() is called when there is no user context, then set user to null.

Related Issue

Motivation and Context

In the log of Travis output, I noticed:

owncloud.log:
{"reqId":"pqAijCPvaiHvZolHHCdO","level":3,"time":"2017-09-05T08:06:49+00:00","remoteAddr":"","user":"--","app":"PHP","method":"--","url":"--","message":"Undefined variable: user at \/home\/travis\/build\/[secure]\/core\/lib\/public\/Util.php#193"}

It is nice to get rid of undefined variable messages.

How Has This Been Tested?

Try logging in and creating files... as a user with this code in place. See that it does not explode.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

👍 nice catch, I saw this error many times

[phil-davis]

Hmmm - I broke unit tests, better have a look.
Update: code changed, all passing now.

[phil-davis]

Previously I tried returning isSharingDisabledForUser() as true when there was no user session found. But that causes problems for stuff like public shares, where the incoming request has no user authentication.
The neatest looking solution is just to set $user to null when there is no user session. self::$shareManager->sharingDisabledForUser($user) already handles that fine and returns false and so when there is no user session, sharing is NOT disabled. This lets public shares and the like work.

While messing with ViewControllerTest.php my IDE indented some stuff to make it consistent. No functional change there, but just nice to have improved indenting while I am there.

@PVince81 please re-review.

[phil-davis]

Backport stable10 #28915
(prospective)

[phil-davis]

@PVince81 please merge if happy - and merge backport also.

Logic was reversed since the approval, please review again.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.