Skip to content

Typo settings_ajax_changegroupname#28740

Merged
DeepDiver1975 merged 1 commit intomasterfrom
changegroupname-typo
Aug 18, 2017
Merged

Typo settings_ajax_changegroupname#28740
DeepDiver1975 merged 1 commit intomasterfrom
changegroupname-typo

Conversation

@phil-davis
Copy link
Contributor

Description

Fix typo of settings_ajax_changegroupname

Related Issue

Is there anything actually broken?

Motivation and Context

This looks wrong.

How Has This Been Tested?

Not tested - if it is used then that could be tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This looks wrong, but I do not see where it is used, so what is broken?

@phil-davis phil-davis added this to the development milestone Aug 18, 2017
@phil-davis phil-davis self-assigned this Aug 18, 2017
@phil-davis phil-davis requested a review from PVince81 August 18, 2017 11:08
@DeepDiver1975
Copy link
Member

this route name is used nowhere - can go in or not - no big difference ...

👍

This looks wrong, but I do not see where it is used, so what is broken?
@phil-davis phil-davis force-pushed the changegroupname-typo branch from 36be78e to 7fb2ee4 Compare August 18, 2017 12:27
@DeepDiver1975 DeepDiver1975 merged commit 387943b into master Aug 18, 2017
@DeepDiver1975 DeepDiver1975 deleted the changegroupname-typo branch August 18, 2017 18:56
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants