Fix check new dav rename target path name

[PVince81]

Description

Verify target path earlier to make sure 403 is returned in case of wrong
target (ex: ".htaccess") instead of 404.

The reason this happens is because the rename code path between old and new DAV endpoints are different. Old DAV fails earlier when Sabre's CorePlugin does a getNodeForPath() on the target even for a local rename. New DAV doesn't go through this code path and reached Node:setName() more directly, possibly due to the necessary changes that were done lately regarding moves.

Related Issue

Fixes #28441.
Should also fix the renameFile/renameFolder failures on master.

Motivation and Context

How Has This Been Tested?

Manual testing with cadaver on new dav endpoint: rename "welcome.txt" to ".htaccess".
Before the fix: 404
After the fix: 403

Automated tests have been reenabled.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

@individual-it I can't find them

[individual-it]

👍 fixes the issue

[individual-it]

sorry did overlooked one file in your commit

[PVince81]

stable10: #28737

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.