Properly set the status text in the ocs response for v2 calls #28570
Properly set the status text in the ocs response for v2 calls #28570
Conversation
6d2217b to
6acdf9b
Compare
| $this->createMock(ISecureRandom::class), | ||
| $configMock | ||
| )); | ||
| $expected = '{"ocs":{"meta":{"status":"failure","statuscode":200,"message":"OK",' . |
There was a problem hiding this comment.
heh even the test had this crazyness? :)
guruz
left a comment
There was a problem hiding this comment.
i haven't tested the PR.
code looks ok (i'm assuming 'failure' is some default string that needs to be overwriten)
|
Looks slightly risky. If this is a regression, what introduced it and when ? |
This regression was introduced with the move-ocs-to-appframework change. It exists since the very first day. But we can also ignore this - nobody with a reasonable client should evaluate that status string |
|
Thanks for the explanation. I agree to merge this then. |
|
@DeepDiver1975 please backport to stable10. Backport further if older versions are affected too. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
For OCS v2 calls the status text for status 200 has to be 'ok' not failure
Related Issue
fixes owncloud/notifications#103
How Has This Been Tested?
Observe OCS responses in the notifications app
Types of changes
Checklist: