Optimize PUT - Dont fetch info of not existing file by mrow4a · Pull Request #28021 · owncloud/core

mrow4a · 2017-05-26T13:05:20Z

"in case the file already exists/overwriting" ? In createFile() function which from composer is used only for new files, and there is specific one called updateFile() ?

-1 query plus Locking/Releasing because each getFileInfo needs to do that

PVince81 · 2017-05-30T11:26:02Z

Did you test ? Is updateFile() called for overwrites and not createfile() ? It is likely that you are right.

From what I remember, an overwrite still goes to File::put() though.

PVince81 · 2017-05-30T11:27:05Z

make sure to test the following:

old endpoint overwrite upload
old endpoint chunked upload+overwrite
new endpoint overwrite upload
new endpoint chunked upload-overwrite

there is a slight chance that the chunked mode will go through createFile() even for overwrites... (yes, messy stuff here...)

PVince81 · 2017-06-21T10:27:19Z

@mrow4a any update on my comments ?

PVince81 · 2017-07-04T10:04:30Z

@mrow4a please rebase. On master I've added chunking + overwrite tests so the integration tests will take care of verifying your change.

If tests pass, then 👍

PVince81 · 2017-07-04T10:04:50Z

let me rebase that for you

PVince81 · 2017-07-05T12:03:00Z

Resuming build at Tue Jul 04 13:24:01 CEST 2017 after Jenkins restart
Ready to run at Tue Jul 04 13:24:02 CEST 2017
13:24:02 Timeout set to expire in 1 hr 29 min

Rebased ⛏

PVince81 · 2017-07-05T15:00:28Z

some apparently legit failures:

16:35:57 --- Failed scenarios:
16:35:57 
16:35:57     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:24
16:35:57     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:74
16:35:57     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:107
16:35:57     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/webdav-related-new-endpoint.feature:482

@mrow4a please have a look

PVince81 · 2017-08-07T08:21:57Z

01:48:30 
01:48:30 --- Failed scenarios:
01:48:30 
01:48:30     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:24
01:48:30     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:74
01:48:30     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/quota.feature:107
01:48:30     /var/lib/jenkins/workspace/owncloud-core_core_PR-28021-LBIG7E7PMTL3SCH6VDBSM2DPVZILEZZV2SKQOI7W3QQLEFOBH4CQ/tests/integration/features/webdav-related-new-endpoint.feature:519
01:48:30

PVince81 · 2017-08-10T07:30:08Z


  | Test Result (2 failures  / -2)OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\UploadTest.testBasicUploadOCA\DAV\Tests\unit\Connector\Sabre\RequestTest\PartFileInRootUploadTest.testBasicUpload
-- | --

mrow4a · 2017-08-10T07:59:41Z

Unit tests are not adjusted because they don't pass PATH_INFO for $SERVER

mrow4a · 2017-08-10T19:11:30Z

@jvillafanez @PVince81 @DeepDiver1975 review here?

PVince81 · 2017-08-10T19:20:33Z

apps/dav/lib/Upload/FutureFile.php

+		$davUploadsTarget = '/dav/uploads';
+
+		// Check if pathinfo starts with dav uploads target and basename is future file basename
+		if (isset($_SERVER['PATH_INFO'])


any way to do this without global variables + static functions ? (pretty sure @DeepDiver1975 would not be happy either)

I do see that it is likely rather tricky to inject all this down to the "File" class.
@DeepDiver1975 should we pass on this one ?

Honestly, it was just the suggestion, but wanted to create a specific class which might hold all these values.

About the global, not sure if request holds this value alone.

PVince81

👍 fine by me

PVince81 · 2017-08-14T14:28:27Z

@mrow4a please backport to stable10

lock · 2019-08-02T20:02:03Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mrow4a added the 3 - To Review label May 26, 2017

mrow4a requested review from DeepDiver1975 and PVince81 May 26, 2017 13:05

mrow4a force-pushed the optimize_put_6 branch from 5ecaab9 to 0c93d5d Compare May 31, 2017 10:48

mrow4a mentioned this pull request Jun 21, 2017

Optimize PUT - don't fetch and update checksum again, reunse the one from part file #27532

Merged

1 task

PVince81 force-pushed the optimize_put_6 branch 2 times, most recently from 7c13305 to 29b81b4 Compare July 5, 2017 12:02

PVince81 added 4 - To release and removed 3 - To Review labels Jul 5, 2017

PVince81 added 2 - Developing and removed 4 - To release labels Jul 5, 2017

mrow4a force-pushed the optimize_put_6 branch 2 times, most recently from 6fc99b9 to 9090ba3 Compare August 3, 2017 08:43

mrow4a force-pushed the optimize_put_6 branch from 9090ba3 to 85d52a8 Compare August 6, 2017 21:17

PVince81 assigned mrow4a Aug 7, 2017

mrow4a force-pushed the optimize_put_6 branch from 85d52a8 to bb913f4 Compare August 9, 2017 21:23

PVince81 added this to the development milestone Aug 10, 2017

mrow4a added 2 commits August 10, 2017 14:19

Dont fetch info of not existing file

a19d632

Do check for future file to query filecache only for future file

ba9d835

mrow4a force-pushed the optimize_put_6 branch from bb913f4 to ba9d835 Compare August 10, 2017 12:26

mrow4a added 3 - To Review and removed 2 - Developing labels Aug 10, 2017

PVince81 reviewed Aug 10, 2017

View reviewed changes

PVince81 approved these changes Aug 14, 2017

View reviewed changes

PVince81 merged commit 3b0f072 into master Aug 14, 2017

PVince81 deleted the optimize_put_6 branch August 14, 2017 14:28

mrow4a mentioned this pull request Aug 16, 2017

Stable10 optimize put #28704

Merged

lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Conversation

mrow4a commented May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented May 30, 2017

Uh oh!

PVince81 commented May 30, 2017 • edited by mrow4a Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PVince81 commented Jun 21, 2017

Uh oh!

PVince81 commented Jul 4, 2017

Uh oh!

PVince81 commented Jul 4, 2017

Uh oh!

PVince81 commented Jul 5, 2017

Uh oh!

PVince81 commented Jul 5, 2017

Uh oh!

PVince81 commented Aug 7, 2017

Uh oh!

PVince81 commented Aug 10, 2017

Uh oh!

mrow4a commented Aug 10, 2017

Uh oh!

mrow4a commented Aug 10, 2017

Uh oh!

PVince81 Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

mrow4a Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

mrow4a Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

PVince81 left a comment

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Aug 14, 2017

Uh oh!

lock bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mrow4a commented May 26, 2017 •

edited

Loading

PVince81 commented May 30, 2017 •

edited by mrow4a

Loading