Conversation
| // Search in contacts | ||
| //@todo Pagination missing | ||
| $addressBookContacts = $this->contactsManager->search($search, ['CLOUD', 'FN']); | ||
| $addressBookContacts = $this->contactsManager->search($search, $searchProperties, [], $this->limit, $this->offset); |
There was a problem hiding this comment.
@butonic thoughts on this? I think we should always include CLOUD and FN since they are needed to represent the user in the search dialog, but allow additional to be provided?
There was a problem hiding this comment.
don't force CLOUD and FN ... but document it. as we just chatted: https://github.com/owncloud/documentation/blob/458ae44c975f635365cdb0abc66648bb3b3f6558/admin_manual/configuration_files/federated_cloud_sharing_configuration.rst#configuration-tips
There was a problem hiding this comment.
probably give an occ command that just adds the email by setting it to CLOUD,FN,EMAIL. Discuss if we should make it the default?
|
Any update here, can I review? |
|
Apart from doubt to @butonic about CLOUD and FN, looks good to me, no doubts here 👍 |
9d08ce6 to
82877b0
Compare
|
|
82877b0 to
b17b6a7
Compare
b17b6a7 to
862c0e2
Compare
|
Rebased to kick jenkins into action |
| */ | ||
| public function search($pattern, $searchProperties, $options) { | ||
| $results = $this->backend->search($this->getKey(), $pattern, $searchProperties); | ||
| public function search($pattern, $searchProperties, $options, $limit, $offset) { |
There was a problem hiding this comment.
add = null to make the params optional or give sane defaults.
lib/public/IAddressBook.php
Outdated
| * @since 5.0.0 | ||
| */ | ||
| public function search($pattern, $searchProperties, $options); | ||
| public function search($pattern, $searchProperties, $options, $limit, $offset); |
There was a problem hiding this comment.
add = null to make the params optional or give sane defaults.
* Use dav appconfig for customisable remote contact search properties * Add limit and offset to remote user search * Implement & fix carddavbackend search tests for limit and offset * Fix sharee test to get search properties from config * Improve sharee controller remote user search tests * Include custom search properties in sharee exact matches * Add explicit sorting of remote user searches * Make addressbook search limit and offset optional
* Use dav appconfig for customisable remote contact search properties * Add limit and offset to remote user search * Implement & fix carddavbackend search tests for limit and offset * Fix sharee test to get search properties from config * Improve sharee controller remote user search tests * Include custom search properties in sharee exact matches * Add explicit sorting of remote user searches * Make addressbook search limit and offset optional
* Use dav appconfig for customisable remote contact search properties * Add limit and offset to remote user search * Implement & fix carddavbackend search tests for limit and offset * Fix sharee test to get search properties from config * Improve sharee controller remote user search tests * Include custom search properties in sharee exact matches * Add explicit sorting of remote user searches * Make addressbook search limit and offset optional
* Use dav appconfig for customisable remote contact search properties * Add limit and offset to remote user search * Implement & fix carddavbackend search tests for limit and offset * Fix sharee test to get search properties from config * Improve sharee controller remote user search tests * Include custom search properties in sharee exact matches * Add explicit sorting of remote user searches * Make addressbook search limit and offset optional
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Implemented paginated searching of (local|remote)addressbooks for improved search performance when searching through (multiple) very large addressbooks.
Also added configurable search properites for remote addressbook contact search - used for shareelookup on remote servers.
Motivation and Context
How Has This Been Tested?
So far: unit tests
Types of changes
Checklist: