fix for #25358#27275
Merged
DeepDiver1975 merged 1 commit intoowncloud:masterfrom Mar 1, 2017
individual-it:fix_for_25358
Merged
fix for #25358#27275DeepDiver1975 merged 1 commit intoowncloud:masterfrom individual-it:fix_for_25358
DeepDiver1975 merged 1 commit intoowncloud:masterfrom
individual-it:fix_for_25358
Conversation
|
@individual-it, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ringmaster, @PVince81 and @DeepDiver1975 to be potential reviewers. |
Contributor
|
👍 thanks |
individual-it
added a commit
that referenced
this pull request
Mar 8, 2017
DeepDiver1975
pushed a commit
that referenced
this pull request
Mar 8, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this fixes the issue #25358 by using the advanced validation from #27257
Related Issue
#25358
Motivation and Context
see #25358
How Has This Been Tested?
function tested by karma unit tests in #27257 + manual testing
would love to have also a selenium UI test for this, cause so far we only test the function but not the behaviour of the application. If someone decide to revert this commit all tests will pass but the bug will be back.
For UI tests we need #27191 to be approved and merged.
Screenshots (if appropriate):
Types of changes
Checklist: