[stable9] Backport flat reshare unit tests

[PVince81]

Since stable9 already has flat reshares, the unit tests need to also use the new sharing API when creating shares to make sure we're testing the correct results.

Also this is required by #26912 which adds a performance fix that uses a shortcut that limits recursion based on the idea that recursion is not needed any more due to flat reshares.

• Backports 6509220 from Remove old ocs share api code #22242 which makes the api tests in files_sharing use the new sharing API which creates shares that respect flat resharing
• Backport unit test fixes from Fix OCS Share API path response #25003 which were missing. Note that the fix from that PR was already backported. I think the unit tests weren't backported because the change from 6509220 was not there so backporting was not possible.

Required for #26912

Please review @SergioBertolinSG @jvillafanez @DeepDiver1975 @VicDeo

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

[jvillafanez]

In general, I've seen several tests that have several calls to OCS. If the tests are about OCS, then only one call to OCS should be done unless the code is explicitly testing other thing (for example, that you get the same data you've created before).

Using the share manager might be enough to get the required information, for example to check that the share is already there and to retrieve it, specially if we don't want to deal with direct DB access.

[PVince81]

@jvillafanez thanks for the review. Please note that this is only a backport of tests that already exist on 9.1 and master. I'm not willing to make any big changes there in the context of a backport.

We could of course improve the tests in the future on master if you think they are not suitable, but I don't think this has high priority right now.

[jvillafanez]

Ok, let's leave it as technical debt 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.