[stable9] Fix share mounting recursion#22945
Conversation
|
backport is obviously fine. please merge as soon as tests pass. Thanks a lot!!! |
|
Code looks good 👍 |
|
Steps to reproduce are here: https://github.com/owncloud/enterprise/issues/1157#issuecomment-193680329 |
|
Fixes the issue 👍 |
|
Smashbox passed locally ✅ |
|
Working fine 👍 |
|
Local Unit test (php7) sqlite ✅ Local Intergration test (php7): sqlite: ✅ (besides the capabilities tests... which also don't pass on master here). |
|
so what is going on with the tests? we need to merge this soon. |
|
On the old unsquashed PR most tests passed: #22937 Integration test is missing, but @rullzer ran them locally and they worked. The unrelated "failed" test you see here was just aborted by @DeepDiver1975 to save some time. We can either wait a bit longer or take the risk and merge it and build packages in parallel. |
|
failed test looks like failure to connect? |
|
@cmonteroluque no, aborted by @DeepDiver1975 |
|
lex-j3 has docker issues - need to reboot - but we did smash it locally 👍 |
[stable9] Fix share mounting recursion
|
Please prepare a master PR @PVince81 |
|
Yessssir |
|
master/9.1: #22950 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixed recursion issue.
Squashed version of #22937 without logging and without extra unused "use" statement.
@nickvergessen @icewind1991 @rullzer @owncloud/qa @cmonteroluque @karlitschek @DeepDiver1975