Scale up the font on larger previews

[nickvergessen]

Fix #15634, #11469

@georgehrke @PVince81

[nickvergessen]

@oparoz

[karlitschek]

👍

[oparoz]

That works for small 36x36 previews

but not for publicly shared links

[oparoz]

I think there are a few open tickets asking for those large previews to be rendered as text directly, but I don't remember what's holding that back.

[nickvergessen]

Well the other idea would be to not use the max-size thumb trick for txt previews. But then we would need to extend the API of the preview providers, so they can specify whether or not they support the max-size trick

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11536/
🚀 Test PASSed.🚀

[scrutinizer-notifier]

The inspection completed: 1 updated code elements

[oparoz]

I don't think the max preview is to blame. This has never worked properly, so it would be best to fix the txt provider imo.

When I stumbled upon #11469, I did the same thing you did and ran into the exact same issue. That was on oC7

[nickvergessen]

@oparoz well but if we use a font size that looks good on the public page (sharing thing), then you get a not-readable 36*36 preview, because that is just a resized version of the public page preview.

[oparoz]

Txt seems to be the only exception, so maybe it best to fix the public page than mess with the preview system?
Maybe use 3 instead of 5 for now so that small previews work and large previews are a bit less bad?
$fontSize = ($maxX) ? (int) ((3 / 36) * $maxX) : 5; //5px

[oparoz]

There are plenty of exceptions already in the public page
https://github.com/owncloud/core/blob/master/apps/files_sharing/js/public.js#L104-L117

[nickvergessen]

Closing in favor of #15652

[nickvergessen]

Okay, not really replaced, since this one fixes the mini previews, while the other one fixes the public page

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11563/
🚀 Test PASSed.🚀

[nickvergessen]

@oparoz

Txt seems to be the only exception, so maybe it best to fix the public page than mess with the preview system?
Maybe use 3 instead of 5 for now so that small previews work and large previews are a bit less bad?
$fontSize = ($maxX) ? (int) ((3 / 36) * $maxX) : 5; //5px

[nickvergessen]

@oparoz I used 5 / 36 because this is the original font size that was used.

[oparoz]

OK

[oparoz]

👍 from me, if used in combination with #15652 and if that's the sane thing to do.

[nickvergessen]

@MorrisJobke another review? ;)

[MorrisJobke]

👍