Fix S3 folder creation for new AWS API

[PVince81]

This also fixes the unit tests

Fixes #11725

S3 unit tests now all pass for me locally.

[PVince81]

Please review @LukasReschke @butonic @helmutschneider @icewind1991

[PVince81]

Basically the new API requires all objects to have a body... in our case we abuse the object store by creating dummy entries for folders. There folders now need to have a (empty) body as well.

[PVince81]

I tested creating a folder over the UI and it also worked fine.

[helmutschneider]

Very strange. In my PR (#10680) to upgrade the sdk I fixed this. Seems it was failing later though: 0d0c9d0

[PVince81]

Not sure, maybe some other change sneaked in and broke it somehow.

[scrutinizer-notifier]

The inspection completed: No new issues

[PVince81]

Just tried 993376f (before this PR) and it's not possible to create folders in the UI. There's an exception "You must specify a non-null value for the Body or SourceFile parameters."

[PVince81]

@helmutschneider your code from d2979da seems correct. It seems your change possibly got lost in a merge conflict resolution 😕

[helmutschneider]

@PVince81 No, that code is only relevant to the touch action (which I noticed was failing). My local tests did not fail on mkdir though which is really weird. Also unlikely that amazon changed their S3 api :/

[PVince81]

@helmutschneider I found the reason: https://github.com/owncloud/core/pull/11375/files#r19245328

There was that other PR to stable7 to fix stuff. When I ported it to master I didn't know I needed to put the "Body" back.

[PVince81]

@helmutschneider it seems the file already had the correct code when you made your change: https://github.com/helmutschneider/core/blob/d2979da864bd7b9759a0efb60e6eed62d79fe473/apps/files_external/lib/amazons3.php#L151
This explains why the unit tests passed back then.

The "Body" part likely got lost when I forward ported #11375

[PVince81]

Anyway, if the change makes sense (and runs for you) I'd appreciate a thumbs up for the review 😄

[helmutschneider]

@PVince81 I don't have time to test right now but I trust your judgement. Code makes sense too. Well done! 👍

[ghost]

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/1001/
🚀 Test PASSed. 🚀

[PVince81]

Thanks!

[LukasReschke]

👍