unreachable clamav in files_antivirus results in visual problems for the user

[individual-it]

Steps to reproduce

1. install the file_antivirus app on current core master branch
2. set some configuration in file_antivirus that does NOT reach clamav
3. upload a file vie WebUI

Expected behaviour

no error shown to the user or an error shown telling about misconfiguration of file_antivirus app

Actual behaviour

file get uploaded correctly but the progress bar hangs in "Processing file" status

This does not happen on the current 10.0.3beta2 tarball so I guess its an core issue

Server configuration

Operating system:
debian
Web server:
apache2
Database:
sqlite
PHP version:
7.1
ownCloud version: (see ownCloud admin page)
10.0.3 beta git (current master branch)
Updated from an older ownCloud or fresh install:
fresh
Where did you install ownCloud from:
git

The content of config/config.php:

{
    "system": {
        "instanceid": "oc9xsmdtnlru",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost"
        ],
        "datadirectory": "\/home\/artur\/www\/owncloud-core\/data",
        "overwrite.cli.url": "http:\/\/localhost\/owncloud-core",
        "dbtype": "sqlite3",
        "logtimezone": "UTC",
        "installed": true,
        "license-key": "***REMOVED SENSITIVE VALUE***",
        "default_language": "en",
        "files_external_allow_create_new_local": "true",
        "theme": "",
        "loglevel": 2,
        "maintenance": false,
        "log_type": "owncloud",
        "dbname": "owncloud",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "debug": true,
        "skeletondirectory": "\/home\/artur\/www\/owncloud-core\/tests\/ui\/skeleton",
        "version": "10.0.3.0",
        "firewall.debug": 1,
        "csrf.disabled": true
    }

List of activated apps:

Enabled:
  - comments: 0.3.0
  - dav: 0.3.1
  - diagnostics: 0.1.0
  - enterprise_key: 0.1.3
  - federatedfilesharing: 0.3.1
  - federation: 0.1.0
  - files: 1.5.1
  - files_antivirus: 0.11.1.0
  - files_external: 0.7.1
  - files_sharing: 0.10.1
  - files_texteditor: 2.2
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - firewall: 2.4.1
  - gallery: 16.0.2
  - market: 0.2.1
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - updatenotification: 0.2.1
Disabled:
  - customgroups
  - multidirtest
  - password_policy
  - testing
  - theme-example

Are you using external storage, if yes which one: local/smb/sftp/...
local
Are you using encryption: yes/no
no
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
FF 55
Operating system:
Debain

Logs

Web server error log

nothing

ownCloud log (data/owncloud.log)

{"reqId":"SqQLyyY6eaTSV19yu9nF","level":2,"time":"2017-08-31T11:31:12+00:00","remoteAddr":"::1","user":"admin","app":"no app in context","method":"PUT","url":"\/owncloud-core\/remote.php\/webdav\/28353-cc_givethanks2_nov13_1100.1100w.tn.jpg","message":"OCA\\Files_Antivirus\\AvirWrapper OCA\\Files_Antivirus\\AvirWrapper::fopen The antivirus executable could not be found at \/usr\/bin\/clamscanss"}

Browser log

nothing

[hodyroff]

IMHO in this case NO file should be uploaded. Obviously the admin wants it to be virus checked - so either this must happen or the file must be denied to be saved.
Yes, we could have better error handling, but it sounds somewhat cosmetic.
I guess the best solution would be in the anti-virus config to make sure that we check if the thing can be reached?! Or I misunderstand something.

[individual-it]

Yes, best would be to notify the admin in the file_antivirus app that the clamav server is not reachable. If it was reachable during setup but went away during operation for some reason, we could stop the upload completely or notify the admin and not annoy the user. (I will open a separate issue for that in file_antivirus)
The described issue here might be a hint to something else because:

1. it does not happen in stable10 branch
2. as core is concerned all went well and the file is uploaded, so why it the UI hanging?

[individual-it]

@hodyroff

1. issue about notifying the admin about not reachable clamAV administrator should be notified if clamav not reachable files_antivirus#180 (fixed)
2. issue about rejecting uploads when clamAV is not reachable reject file uploads when clamAV is not reachable files_antivirus#181 (fixed)

[individual-it]

the problem with the hanging progress bar started with #28842 and is now also reproducible in stable10 since #28861
@PVince81 ?

[PVince81]

there are more PRs to come, also need #28692

[PVince81]

for the progress bar fix

[VicDeo]

@PVince81 #28692 was merged.
I guess hanging progress bar is fixed now?

[PVince81]

I guess hanging progress bar is fixed now?

Now it's hanging on "Processing..." instead of "A few seconds left". So... yes 😉

[PVince81]

ah, and the other causes of hanging should be fixed already too (timeout/cancel/drop)