Re-add missing cron jobs

[PVince81]

In some setups, there are some OC cron jobs that went missing.

Ideal would be to have a command and also a repair step at upgrade that will re-add these in case they are missing.

I believe that in the past some jobs were only added at install time or whenever the app got enabled, and then not any more. Then in 9.1 we moved the job names to info.xml, which will make it possible for automatic repair.

@DeepDiver1975 or do we have that already ?

CC @cdamken

[DeepDiver1975]

As of today background jobs which are defined in info.xml are recreated on app installation and on update.

We can also make this part of the occ repair step

[jnweiger]

I am studying this with @cdamken :
Trashbin does not define a background job in info.xml -- how is trashbin_retention_obligation implemented?

Wondering, as for versions_retention_obligation we have
OCA\Files_Versions\BackgroundJob\ExpireVersions

[PVince81]

@jnweiger only recurring jobs (ones that are never auto-deleted) are added through info.xml or other APIs.

The trashbin and versions apps will dynamically add one-time jobs into the list.

[cdamken]

I see that in update.php and install.php (in both: files_version and files_trasbin) are the right entries:

\OC::$server->getJobList()->add('OCA\Files_Trashbin\BackgroundJob\ExpireTrash');

and

\OC::$server->getJobList()->add('OCA\Files_Versions\BackgroundJob\ExpireVersions');

The question is why and when are the entries erased?

[PVince81]

Hmm, these are the recurrent jobs. They should never be erased.

Maybe someone thought that clearing the whole oc_jobs table would help and mistakenly erased them ?

[PVince81]

This should now be easier to implement when based on info.xml which contains the list of jobs that needs to be registered.

[PVince81]

AFAIK there is no logic to erase permanent jobs, except maybe on app uninstall.
It is likely an admin error who decided to clear the whole table.

Moving to backlog for now.

@DeepDiver1975

[butonic]

OCA\Files_Trashbin\BackgroundJob\ExpireTrash and OCA\Files_Versions\BackgroundJob\ExpireVersions will kill large ldap setups because they run every 15 min but might take hours to iterate over all users.

we added dedicated occ commands down to oc 8.2: #25917

They should be used with dedicated cron jobs and the entries in oc_jobs must be deleted.

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.