Added init command#13
Open
dvirsky wants to merge 2 commits intoowenthereal:masterfrom
Open
Conversation
Signed-off-by: Dvir Volk <dvirsky@gmail.com>
…them Signed-off-by: Dvir Volk <dvirsky@gmail.com>
Owner
There was a problem hiding this comment.
We could call go list -e -json ./... to return all deps in current path instead of traversing folders. It requires some code changes in https://github.com/jingweno/nut/blob/master/pkg.go#L246 though.
Owner
|
Sorry for the late reply. It looks good to me in general. I made some comments on improvement. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is following #12 - no tests but I wanted you to have a look first. Let me know how do you think it should be tested, as it's not trivial.
My initial thought is to create a temporary GOPATH, go get some known package, and init nut on it.