fix: add automatic Connection header for Node.js HTTP compatibility #21889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements automatic Connection header behavior to match Node.js: - Automatically adds "Connection: keep-alive" when no Connection header is set - Automatically adds "Connection: close" when connection should be closed - Respects user-provided Connection headers - Respects explicitly removed Connection headers (via removeHeader) Fixes Node.js HTTP compatibility by ensuring proper HTTP/1.1 keep-alive behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
src/bun.js/bindings/NodeHTTP.cpp
Outdated
| } | ||
| } | ||
| if (!hasConnectionHeader) { | ||
| for (auto& header : internalHeaders.uncommonHeaders()) { |
- Remove complex FetchHeaders header checking as suggested by @Jarred-Sumner - Keep the basic automatic Connection header logic for regular header objects - Maintain Node.js compatibility for automatic HTTP headers Addresses review comment: "not necessary" regarding FetchHeaders complexity 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
test-http-automatic-headers.js- verifies automatic Connection header additiontest-http-remove-connection-header-persists-connection.js- verifies removeHeader behavior🤖 Generated with Claude Code