Add regression test for issue #21642: bundler self-importing modules #21886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test case that reproduces issue #21642 where the bundler generates circular async dependencies that cause init functions to be called before they are defined, resulting in "undefined is not an object" runtime errors. The test is marked as TODO since the issue is not yet fixed. The proper fix requires implementing the TODO comment in LinkerContext.zig to store promises and await them after all imports but before module code execution. Test case reproduces the exact scenario from the issue: - e0.ts and e1.ts are entry points - e2.ts has circular dependencies with async imports - Results in generated code where init_e0() is called before init_e0 is defined 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
|
Updated 10:55 PM PT - Aug 14th, 2025
❌ Your commit 🧪 To try this PR locally: bunx bun-pr 21886That installs a local version of the PR into your bun-21886 --bun |
Member
|
lol you didnt even fix anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for issue #21642 where the bundler generates circular async dependencies that cause runtime errors.
Problem
The bundler currently generates invalid JavaScript when modules have circular dependencies with async imports. Specifically:
e0.tsande1.tsare entry pointse2.tshas circular dependencies with async imports frome0init_e0()is called beforeinit_e0is definedTest Plan
Next Steps
The proper fix requires implementing the TODO comment in
LinkerContext.zig:1162-1164:This is a significant architectural change that needs careful consideration of:
Related
findAllImportedPartsInJSOrder.zig🤖 Generated with Claude Code