devserver: fix watching entrypoint #21874
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 2:49 PM PT - Aug 18th, 2025
❌ @autofix-ci[bot], your commit ff58806 has 5 failures in
🧪 To try this PR locally: bunx bun-pr 21874That installs a local version of the PR into your bun-21874 --bun |
Jarred-Sumner
requested changes
Aug 15, 2025
Collaborator
Jarred-Sumner
left a comment
There was a problem hiding this comment.
- What keeps the file paths in the hash table alive?
- stat on every file? is that the best we can do here?
- is there a way to reduce the potential of TOUTTOC bugs here? can re-opening a file for watching happen and that removes the stat() call and means fewer syscalls?
…ven-sh/bun into zack/devserver-fix-watching-entrypoint
- Add deleted_entrypoints field to VoidFieldTypes initialization in memory_cost.zig - Handle macOS-specific GuardedValue memory cost calculation for DeletedEntrypointWatchlist - Make DeletedEntrypointWatchlist.Entry public to allow @sizeof access from memory_cost.zig 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ven-sh/bun into zack/devserver-fix-watching-entrypoint
- Remove duplicate deleted_entrypoints field in VoidFieldTypes struct - Make DeletedEntrypointWatchlist.Entry public for external access - Fix SmallList API usage: replace .items with .slice() method - Add memoryCostSmallList helper function for SmallList memory calculation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace std.StringArrayHashMapUnmanaged with bun.StringArrayHashMapUnmanaged for better performance - Fix Windows EPERM error in vim-file-swap test by using fs.renameSync instead of fs.cpSync 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21042
Fixes an issue where editing an entrypoint in Vim would not hot reload