Fix abort handler in "ws" polyfill #21867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This does two things:
wsmodule when running websocket.test.js. This was caused by theopencallback firing before the.upgradefunction call returns. We need to update thesocketvalue on the ServerWebSocket to ensure theNodeHTTPResponseobject is kept alive for as long as it should be, but theus_socket_taddress can, in theory, change due toreallocbeing used when adopting the socket._httpMessageproperty is not set when a socket is upgradedHow did you verify your code works?
There is a test and the asan error no longer triggers