ai slop #21861
Closed
ai slop #21861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #15310 where CSS imports with type attributes were being stripped during transpilation. - Preserve 'with { type: "css" }' and 'with { type: "json" }' in transpiler output as these are web standard import attributes - Keep Bun-specific attributes (toml, sqlite, etc.) only when is_bun_platform is true to maintain compatibility - Add comprehensive regression tests This ensures compatibility with the standard CSS modules proposal while maintaining Bun's extended import capabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
…ests - Moved tests to separate file to avoid interfering with existing import-attributes tests - Tests specifically target transpiler behavior for issue #15310 - All tests pass and verify the fix works correctly
- Add 'webassembly' mapping to wasm loader in options.zig - Update transpiler to preserve all web standard import attributes: - CSS (type: 'css') - JSON (type: 'json') - WebAssembly (type: 'webassembly') - Add comprehensive tests for WebAssembly import attributes - Ensure Bun-specific attributes are still handled correctly This completes the fix for issue #15310 by supporting all three major web standard import attribute types while maintaining backward compatibility with Bun's extended capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been marked as AI slop and the description has been updated to avoid confusion or misleading reviewers.
Many AI PRs are fine, but sometimes they submit a PR too early, fail to test if the problem is real, fail to reproduce the problem, or fail to test that the problem is fixed. If you think this PR is not AI slop, please leave a comment.