feat(types): add decompress to fetch() #21855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing TypeScript definitions for two fetch() options that already work at runtime but require @ts-ignore in TypeScript.
Member
|
|
Per maintainer feedback, highWaterMark is not implemented in Bun's fetch() (only in Bun.serve()). Keeping only decompress which is supported.
Contributor
Author
Ahh sorry about that @alii ! I've updated the PR to remove |
alii
approved these changes
Aug 15, 2025
Member
|
Thanks! 🤩 |
Member
|
Approved CI to run. Sometimes things pop up even in just types, so it's worth just checking. Will merge if all is ok |
Member
|
The failing tests are flaky, so happy to merge this. Thanks for the contribution |
Contributor
Author
|
Awesome, happy to contribute! Thanks @alii. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add TypeScript definition for the
decompressoption infetch().Why
This option works at runtime but requires
@ts-ignorein TypeScript:Before:
After:
decompress: falseHow
Added the decompress property to BunFetchRequestInit interface with JSDoc documentation.