Skip to content

Conversation

@dylan-conway
Copy link
Member

What does this PR do?

Same fix as nodejs/node#52915, thanks @huseyinacacak-janea! Bun's implementation of toNamespacedPath is the same code adapted to zig, so the same bug existed.

@github-actions
Copy link
Contributor

@dylan-conway, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/node/tls/node-tls-context.test.ts 1 failing

💻 1 failing tests Darwin x64 baseline

  • test/js/bun/test/test-test.test.ts 1 failing

💻 2 failing tests Darwin x64

  • test/js/bun/test/test-test.test.ts 1 failing
  • test/js/web/streams/streams.test.js 1 failing

🐧💪 1 failing tests Linux AARCH64

  • test/js/bun/http/serve-body-leak.test.ts 1 failing

🐧🖥 1 failing tests Linux x64 baseline

  • test/js/node/child_process/child_process-node.test.js 1 failing

🐧🖥 1 failing tests Linux x64

  • test/js/bun/http/serve-body-leak.test.ts 1 failing

🪟💻 12 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing
  • test/js/bun/http/serve-body-leak.test.ts 1 failing
  • test/js/bun/test/test-test.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/tls/node-tls-context.test.ts code 1
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

🪟💻 9 failing tests Windows x64

  • test/bundler/large_asset_regression.test.ts 1 failing
  • test/cli/install/bun-create.test.ts 1 failing
  • test/cli/install/bunx.test.ts 1 failing
  • test/js/bun/shell/leak.test.ts 1 failing
  • test/js/bun/spawn/spawn.test.ts 1 failing
  • test/js/bun/test/test-test.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/tls/node-tls-context.test.ts code 1
  • test/js/node/watch/fs.watchFile.test.ts SIGKILL

View logs

@Jarred-Sumner Jarred-Sumner merged commit 06231b5 into main May 27, 2024
@Jarred-Sumner Jarred-Sumner deleted the dylan/to-namespaced-path-bugfix branch May 27, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants