Version 0.5.0: Bug fixes, new verbose argument, and deprecating deduped_map#4
Merged
Conversation
…d improve error messaging.
…mprove swap_arg readability and add a guard for when a function without a first argument is called.
…input (in case f changes names).
…an uncommon edge case.
…ment with messaging. Updated tests.
Owner
Author
|
fixes #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
deduped()andwith_deduped()gain a newverboseargument which addsinformative deduplication messaging if TRUE, either by passing the argument or
setting the new global
options(deduped.verbose = TRUE).deduped()now has early exits for inputs of length <= 1 or when noduplication is found.
Bug Fixes
deduped()now drops names iff()drops names, but keeps input namesotherwise. Previously it always kept input names (fixes deduped(f)() preserves input names when f() drops names #5).
Deletion of deduped_map()
deduped_map()has now been completely deleted and the "Suggests" dependenceon purr has been removed. The function was deprecated with a warning in
0.2.0 and has no documented usage on github or cran.
Minor updates
with_deduped()for malformed inputs (e.g. not a call tree,or a call with no first argument to deduplicate.)