Fix api.py logic for corrupt cookie jar and added test cases for the same#1085
Open
arnchlmcodes wants to merge 3 commits intoopenzim:mainfrom
Open
Fix api.py logic for corrupt cookie jar and added test cases for the same#1085arnchlmcodes wants to merge 3 commits intoopenzim:mainfrom
arnchlmcodes wants to merge 3 commits intoopenzim:mainfrom
Conversation
audiodude
requested changes
Mar 16, 2026
Member
audiodude
left a comment
There was a problem hiding this comment.
Wow sorry, this fell off my radar. Sorry about that. The code looks good but I'm worried about the tests.
54e9227 to
84fc761
Compare
Contributor
Author
|
Could you please tell me what concerns you have regarding the tests, happy to address it right away, |
audiodude
requested changes
Mar 19, 2026
audiodude
requested changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a try/except so if the cookie file is broken or corrupted, it deletes it so the program can start fresh.
also added two tests in api_test.py, one to verify that the error handling works and the file gets deleted if it's corrupt and the other test to verify the recovery works and the bot continues and logs in.
ran the ci pipeline locally and made sure everything works.
closes #443