Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 4 4
Lines 376 376
Branches 48 37 -11
=======================================
Hits 347 347
Misses 25 25
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@josephlewis42 I've updated the dependencies before the release, would be happy to have your feedback on this (tests are OK and I ran cpp succesfully) |
josephlewis42
approved these changes
Nov 13, 2024
Collaborator
josephlewis42
left a comment
There was a problem hiding this comment.
LGTM, I also ran Vue to confirm.
Would you enable squash merging on this repo so these two commits will be squashed? That'll also help the dev loop to prevent the need for --amend and --force constantly.
Contributor
Author
|
Let's give it a try with squash and merge, no strong opinion on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASinstead ofasLABEL key=valueinstead ofLABEL key value