opennds: update to version 11.0.0#1184
Closed
itay-sho wants to merge 2 commits into
Closed
Conversation
Release notes: https://github.com/openNDS/openNDS/releases/tag/v11.0.0 Install new files added upstream: - ndscfg library wrapper (to /usr/bin, called via PATH by binauth_log.sh) - check_reauth_interval.sh binauth extension - theme_trusted_only.sh and theme_allow_all.sh ThemeSpec scripts Note: openNDS 11.0.0 requires the UCI config to use a named section (config opennds 'setup') and aborts on startup otherwise. Existing configs from 10.x (anonymous section) must be migrated manually as /etc/config/opennds is a conffile and is preserved on upgrade. Signed-off-by: Itay Shoshani <itai.sho@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the OpenWrt opennds package recipe to upstream openNDS v11.0.0, including installing additional upstream helper scripts/binaries required by the new release.
Changes:
- Bump
PKG_VERSIONto11.0.0, resetPKG_RELEASE, and updatePKG_HASH. - Install the new
ndscfgwrapper into/usr/bin. - Install new binauth/theme helper scripts added upstream.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $(CP) $(PKG_BUILD_DIR)/forward_authentication_service/PreAuth/theme_user-email-login-basic.sh $(1)/usr/lib/opennds/ | ||
| $(CP) $(PKG_BUILD_DIR)/forward_authentication_service/PreAuth/theme_user-email-login-custom-placeholders.sh $(1)/usr/lib/opennds/ | ||
| $(CP) $(PKG_BUILD_DIR)/forward_authentication_service/PreAuth/theme_trusted_only.sh $(1)/usr/lib/opennds/ | ||
| $(CP) $(PKG_BUILD_DIR)/forward_authentication_service/PreAuth/theme_allow_all.sh $(1)/usr/lib/opennds/ |
openNDS 11.0.0 requires the UCI config to use a named 'setup' section and aborts on startup otherwise. Since /etc/config/opennds is a conffile, upgrading from 10.x preserves the old anonymous section as-is, leaving the service unable to start until manually migrated. Add a postinst that renames an existing anonymous @openNDS[0] section to 'setup' when no named setup section exists yet, and restarts the service so the fix takes effect immediately rather than waiting for the next respawn or reboot. Reported-by: copilot-pull-request-reviewer[bot] Signed-off-by: Itay Shoshani <itai.sho@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
@itay-sho @BKPepe If @itay-sho would care to discuss any proposed changes, these should be brought up in the first instance as Github Issues at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
https://github.com/openNDS/openNDS/releases/tag/v11.0.0
Install new files added upstream:
Note: openNDS 11.0.0 requires the UCI config to use a named section (config opennds 'setup') and aborts on startup otherwise. Existing configs from 10.x (anonymous section) must be migrated manually as /etc/config/opennds is a conffile and is preserved on upgrade.
Maintainer: @bluewavenet
Compile tested: Banana Pi R4, 25.12, aarch64 (Filogic)
Run tested: Banana Pi R4, 25.12, aarch64 (Filogic) — confirmed end-to-end: after migrating /etc/config/opennds to the required named 'setup' section, openNDS 11.0.0 started cleanly, a client connected to the guest network, completed the FAS captive portal flow, and reached Authenticated state (verified via
ndsctl json) with real upload/download traffic passing afterward.Description:
opennds: update to version 11.0.0