[fix] Fixed user defined commands that do not require input#871
Merged
Conversation
pandafy
force-pushed
the
fix-send-commands
branch
2 times, most recently
from
June 12, 2024 16:36
d9fc627 to
79d044e
Compare
Bugs: - The "Send Command" operation was failing if the user defined command does not require an input. - The command.js was relying on presence of "reboot" default command. The JS would run into error in absence of the default "reboot" command and the loading overlay would not be hidden. This patch fixes the above mentioned bugs.
pandafy
force-pushed
the
fix-send-commands
branch
from
June 12, 2024 17:21
79d044e to
3011743
Compare
nemesifier
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs:
This patch fixes the above mentioned bugs.