[fix] Add WritableCommandInline when user has change permission#854
Merged
Conversation
nemesifier
requested changes
May 2, 2024
nemesifier
left a comment
Member
There was a problem hiding this comment.
See my comment below.
The test looks goot to me and fails on master as expected.
Add WritableCommandInline to the DeviceAdmin only when the user has change permission for Command model.
pandafy
force-pushed
the
load-writable-command-inline-change-perm
branch
from
May 3, 2024 10:57
e31d0a4 to
b0aebef
Compare
nemesifier
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WritableCommandInline to the DeviceAdmin only when the user has change permission for Command model.