[fix] Fixed device group filter label in device list #1071 - #1129
Merged
nemesifier merged 3 commits intoSep 30, 2025
Merged
Conversation
Replaced "Shared systemwide (no organization)" with "-" in the device group filter dropdown of the device list view, while keeping the original label unchanged elsewhere. Fixes openwisp#1071
nemesifier
reviewed
Sep 30, 2025
nemesifier
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #1071
Description of Changes
This PR fixes the label shown in the device group filter on the device list view.
Previously, when selecting the “no group” option, the dropdown displayed “Shared systemwide (no organization)”, which was confusing in this context.
Now, the filter shows a concise “-” instead, making it clearer and more user-friendly.
Other filters and widgets still display the original label unchanged.
(A copy of
widget_attrswas created before updating it to ensure that only this filter’s widget behavior is modified, without unintentionally affecting other filters that also inherit fromMultitenantRelatedOrgFilter.)Screenshot