[change] Auto add default/required templates and make consistent with credentials auto_add

[nemesifier]

When a template is flagged as default/required (either a new template or an existing non default/required is flagged as default/required), right now existing devices which would qualify to have the new template don't get it assigned automatically.

This is inconsistent with credentials with auto_add which do get added automatically to existing devices.

We should improve this and make the two features consistent and more explicit.

We may do it in different ways:

• simply warn the user that by enabling these features automatically adds the templates/credentials to any qualifying device
• add a confirmation page in which they are able to choose (but I wonder if this is really necessary, I personally don't see this as very useful)

[Sreejith2]

I would like to contribute in this i am new to opensource can you please give me instructions?

Got bitten by this today. Yeah you have to go to each device and "save" the config again. Not intuitive, since the config is already marked as requried.

[DragnEmperor]

@nemesifier I looked into it and found the following observations:
Devices created via Admin

• Default templates: Not assigned automatically to either existing or new devices.
• Required templates: Not assigned automatically to either existing or new devices.
• Access Credentials (auto add : True): Not assigned automatically to either existing or new devices.

Devices created via REST API:

• Default templates: Assigned automatically to new devices but not to existing devices.
• Required templates: Assigned automatically to both existing and new devices.
• Access Credentials (auto add : True): Assigned automatically to both existing and new devices.

Are we expecting consistent behavior across all cases?

[devkapilbansal]

Haven't checked the current behaviour myself but ideally, we should have consistent behaviour.

[nemesifier]

@nemesifier I looked into it and found the following observations: Devices created via Admin

• Default templates: Not assigned automatically to either existing or new devices.
• Required templates: Not assigned automatically to either existing or new devices.
• Access Credentials (auto add : True): Not assigned automatically to either existing or new devices.

This is correct.

Devices created via REST API:

• Default templates: Assigned automatically to new devices but not to existing devices.

Correct.

• Required templates: Assigned automatically to both existing and new devices.

AFAIK this is not correct, are you sure @DragnEmperor?

• Access Credentials (auto add : True): Assigned automatically to both existing and new devices.

AFAIK this is not correct, are you sure @DragnEmperor?

Are we expecting consistent behavior across all cases?

Yes, we must make it consistent.

[pandafy]

• Access Credentials (auto add : True): Not assigned automatically to either existing or new devices.

@DragnEmperor was the celery worker running when you performed this test?

[DragnEmperor]

@nemesifier I looked into it and found the following observations: Devices created via Admin

• Default templates: Not assigned automatically to either existing or new devices.
• Required templates: Not assigned automatically to either existing or new devices.
• Access Credentials (auto add : True): Not assigned automatically to either existing or new devices.

This is correct.

Devices created via REST API:

• Default templates: Assigned automatically to new devices but not to existing devices.

Correct.

• Required templates: Assigned automatically to both existing and new devices.

AFAIK this is not correct, are you sure @DragnEmperor?

• Access Credentials (auto add : True): Assigned automatically to both existing and new devices.

AFAIK this is not correct, are you sure @DragnEmperor?

Are we expecting consistent behavior across all cases?

Yes, we must make it consistent.

@nemesifier Yes, attaching a video for reference

TestingAutoAdd.mp4

• Access Credentials (auto add : True): Not assigned automatically to either existing or new devices.

@DragnEmperor was the celery worker running when you performed this test?

@pandafy Yes, devices added via admin have no config thus leading to auto_add of access credentials excluding them.