[chores:qa] Fixed run-qa-checks script not propagating lint fail

[nemesifier]

Fixed run-qa-checks script not propagating lint fail

[coderabbitai]

📝 Walkthrough

Walkthrough

The run-qa-checks script's lint step was modified to properly propagate failures. Previously, when yarn lint failed, the script would print a guidance message but continue execution. The change wraps the error handling in a subshell, causing the script to exit with status 1 upon lint failure, ensuring error propagation due to the set -e flag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and lacks required sections from the template such as checklist items, issue reference, and detailed change description.	Add the required checklist items, reference the issue number (PR 487), and provide a detailed description of the changes made to the script.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing the run-qa-checks script to properly propagate lint failures.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c25569f and 3c3219c.

📒 Files selected for processing (1)

• run-qa-checks

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Tests and Coverage

🔇 Additional comments (1)

run-qa-checks (1)

5-5: LGTM — lint failures now propagate as intended.

This correctly forces a non-zero exit when yarn lint fails, aligning with set -e.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}