fix bugs with answerHints from issue #964

[Alex-Jordan]

This fixes the issues discussed in #964.

[Alex-Jordan]

Thanks @dpvc. This now also addresses #872.

[Alex-Jordan]

Each issue has a MWE problem to test. For me, they both work following these changes.

[pstaabp]

This fixes #872, however I'm not seeing answer hints show up at all for the various MWEs. Reading through #964 we need to implement the translation between the answer and the internal value like @dpvc pointed out, but that doesn't work for me either.

[Alex-Jordan]

I thought we merged this yesterday and so last night, I closed the two issues tied to this. Sorry!

[drgrice1]

This looks good, and works well in my testing. This makes answer hints work well with parserRadioButtons.pl, parserCheckboxLists.pl, and parserPopUp.pl answers. See my comments on this in #964.

It is also good to fix the reference address issue.

[drgrice1]

I realized that I forgot to test issue #872 with this. The answer hints in the original MWE in that issue still do not work with this pull request. However, the errors that were begin shown are fixed.

I added the suggestion of @dpvc to the MWE and that does get the answer hints to work (you need to replace backslashes with two tildes though do to translation). Here is the MWE that works:

DOCUMENT();
loadMacros('PGstandard.pl', 'PGML.pl', 'parserNumberWithUnits.pl', 'answerHints.pl');

$ans = NumberWithUnits('1 m');
$cmp = $ans->cmp->withPostFilter(sub {
	my $ansHash = shift;
	if ($ansHash->{student_ans} =~ m/^~~s*(?:~~d+(?:~~.~~d*)?|~~.~~d+)~~s*$/) {
		$ansHash->{student_value}   = main::Real($ansHash->{student_ans});
		$ansHash->{student_formula} = main::Formula($ansHash->{student_value});
	}
	return $ansHash;
})->withPostFilter(AnswerHints(2 => [ 'no', replaceMessage => 1 ]));

BEGIN_PGML
Enter [`[$ans]`].

[_]{$cmp}{10}
END_PGML
ENDDOCUMENT();

[Alex-Jordan]

Do I understand right that this can be merged, and #964 can remain closed, but #872 should be reopened but with extended comments? I think we ultimately want something where you do not have to insert that postFilter, and so #872's original MWE remains an issue although not quite for the same reasons. Or maybe #872 remains closed but I open a new issue.

[drgrice1]

This can be merged. If you want to re-open #872 or create another issue regarding creating an easier way to make answer hints work with radio buttons or checkboxes, that would be good.