Changing model for public one - #4060
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a generation_config.json file for the VLM NPU demo to ensure the model stops generating after producing the correct answer (by setting proper EOS/pad token IDs). It also updates the demo README with instructions to download this config, and separately unpins dependency versions in the agentic AI demo requirements.
Changes:
- Added
demos/vlm_npu/generation_config.jsonwith EOS/BOS/pad token IDs for Phi-3.5-vision-instruct - Updated
demos/vlm_npu/README.mdwith acurlcommand to download the generation config - Removed version pins from
openai-agentsandopenaiindemos/continuous_batching/agentic_ai/requirements.txt
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
demos/vlm_npu/generation_config.json |
New generation config specifying BOS, EOS, and pad token IDs |
demos/vlm_npu/README.md |
Added curl command to download the generation config after model export |
demos/continuous_batching/agentic_ai/requirements.txt |
Removed version pins for openai-agents and openai |
You can also share your feedback on Copilot code review. Take the survey.
Collaborator
Author
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
przepeck
force-pushed
the
przepeck/unicode_python_fix
branch
from
March 16, 2026 12:27
8e02aac to
a7dfc85
Compare
Collaborator
Author
dtrawins
approved these changes
Mar 18, 2026
rasapala
approved these changes
Mar 23, 2026
porlows1
pushed a commit
that referenced
this pull request
May 28, 2026
### 🛠 Summary [CVS-181828](https://jira.devtools.intel.com/browse/CVS-181828) Adding corrected generation config to demo to stop model generation after correct answer. ### 🧪 Checklist - [ ] Unit tests added. - [ ] The documentation updated. - [ ] Change follows security best practices. `` --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-181828
Adding corrected generation config to demo to stop model generation after correct answer.
🧪 Checklist
``