Merged
Conversation
Collaborator
Author
|
@ales-otf you may be interested in the implementation of a guard for the rate limiting |
sam0x17
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor CheckColdkeySwap from TransactionExtension to DispatchGuard
Motivation
The previous
CheckColdkeySwapimplementation was aTransactionExtensionthat manually unwrapped one level of proxy calls to find the real account. This was fragile — nested proxies (proxy(proxy(real, call))) could bypass the check entirely.By moving to a
DispatchGuard, the check fires at everycall.dispatch(origin)site, including inside the proxy pallet'sdo_proxy(). This automatically handles any nesting depth with the real resolved origin, without any manual proxy unwrapping.Changes
CheckColdkeySwapTransactionExtensionwith aDispatchGuardimplementation in a newguards/moduleColdkeySwapActiveandColdkeySwapDisputedpallet errors.SubtensorTransactionExtensionby removing the inlined guard call and its extra trait boundsColdkeyInSwapScheduleCustomTransactionErrorvariant (coldkey swap now uses announcements and the check moved to the DispatchGuard) and removed the unusedColdkeySwapDisputedandInvalidRealAccountvariantsTest coverage
NoneandRootorigins bypass the guardremark,add_stake,remove_stake,set_weights,register_network)announce_coldkey_swap,swap_coldkey_announced,dispute_coldkey_swap,submit_encrypted)