Enable multi-namespace support#91
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom Mar 5, 2026
Merged
Enable multi-namespace support#91openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom
openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
dd6cd4b to
02fc25a
Compare
umago
reviewed
Mar 5, 2026
Contributor
umago
left a comment
There was a problem hiding this comment.
Looks good overall, two comments but not blockers
The operator needs to access resources in the openstack namespace while running in the openshift-lightspeed namespace. This enables the operator to be deployed alongside OpenShift Lightspeed operator in its default namespace while managing OpenStack resources in a separate namespace. Note that OpenShift Lightspeed does not behave properly when in a different namespace. We can revisit the namespace where our operator gets deployed once we migrate to Lightspeed Core.
02fc25a to
38af111
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
37f1651
into
openstack-lightspeed:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator needs to access resources in the openstack namespace while running in the openshift-lightspeed namespace. This enables the operator to be deployed alongside OpenShift Lightspeed operator in its default namespace while managing OpenStack resources in a separate namespace.
Note that OpenShift Lightspeed does not behave properly when in a different namespace. We can revisit the namespace where our operator gets deployed once we migrate to Lightspeed Core.